Attention is currently required from: fixeria, dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28636 )
Change subject: ts_31_102: Add support for obsolete EF.RPLMNAcT
......................................................................
Patch Set 2:
(1 comment)
File pySim/ts_31_102.py:
https://gerrit.osmocom.org/c/pysim/+/28636/comment/a0fea819_21fc76ad
PS1, Line 751: def _decode_record_hex(self, in_hex):
Something is wrong here, _decode_record_hex() must be a method of class EF_RPLMNAcT I guess, not a s […]
thanks, nice catch. In my use case I'm only seeing a SELECT for that file which fails, so I never get to the point of payload decode...
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/28636
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic7163b2a01f64ef1223cf15b8d0813d3edf5b61a
Gerrit-Change-Number: 28636
Gerrit-PatchSet: 2
Gerrit-Owner: laforge
laforge@osmocom.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Mon, 18 Jul 2022 07:36:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Gerrit-MessageType: comment