Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39021?usp=email )
Change subject: rspro_client: Make struct osmo_rspro_client private ......................................................................
Patch Set 2: Code-Review-1
(1 comment)
File src/rspro_client_fsm.h:
https://gerrit.osmocom.org/c/osmo-remsim/+/39021/comment/ec63c7ba_e56b2eff?u... : PS2, Line 23: struct osmo_rspro_client {
AFAICT this object is actually not implemented anywhere, so I'd say we can totally drop it instead? […]
it seems you're correct. To be honest, I don't recall by now why this was implemented....
Looking at the git commit log, there is ``` commit 511c51313d4b1994eaa5faebcf01e8e24fb8b5a5 Author: Harald Welte laforge@gnumonks.org Date: Wed Oct 3 23:19:58 2018 +0200
remove rspro_client.c which is not used anyway.
This was more or less a copy+paste of other related code we already have for other IPA based protocols in libosmo*. ```
which removes the rspro_client.c file. IT seem the related code has simply not been removed from the header.
So instead of moving the declarations around, please remove them completely.
-
laforge