osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35145?usp=email ) Change subject: sockaddr_str.h Fix OSMO_SOCKADDR_STR_FMT_ARGS_NOT_NULL syntax error ...................................................................... sockaddr_str.h Fix OSMO_SOCKADDR_STR_FMT_ARGS_NOT_NULL syntax error It's fine changing the define because due to the previous error it means basically that it was never used so far, because using it triggers a compilation error. The error was introduced because I ended up not using this in the past after submitting this code, and now that I want to use it it went noticed that it fails. Change-Id: Iee361d740845257fa62c9093e30e8079fa933827 (cherry picked from commit d9a5c8d32f10af0479c87b957fd7e23cecb8fcce) --- M include/osmocom/core/sockaddr_str.h 1 file changed, 19 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/include/osmocom/core/sockaddr_str.h b/include/osmocom/core/sockaddr_str.h index 2d3e7e9..c646f49 100644 --- a/include/osmocom/core/sockaddr_str.h +++ b/include/osmocom/core/sockaddr_str.h @@ -63,7 +63,7 @@ ((R)->af == AF_INET6) ? "[" : "", \ (R)->ip, \ ((R)->af == AF_INET6) ? "]" : "", \ - (R)->port : 0 + (R)->port #define OSMO_SOCKADDR_STR_FMT_ARGS(R) \ ((R) && (R)->af == AF_INET6) ? "[" : "", \ (R) ? (R)->ip : "NULL", \ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35145?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: osmith/1.9.2 Gerrit-Change-Id: Iee361d740845257fa62c9093e30e8079fa933827 Gerrit-Change-Number: 35145 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged