Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30321 ) Change subject: osmo_pfcp_ip_addrs_set(): do not set port number ...................................................................... Patch Set 1: Code-Review+2 (2 comments) Patchset: PS1: combine votes File src/libosmo-pfcp/pfcp_msg.c: https://gerrit.osmocom.org/c/libosmo-pfcp/+/30321/comment/37898af2_b875e635 PS1, Line 504: dst->v4 = *addr; i find it conceptually simpler to set the port number to zero instead... -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30321 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Ib29a123c06d459c99d7c1c0b9a7694fb78cd9fd8 Gerrit-Change-Number: 30321 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 13:47:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment