Attention is currently required from: matanp, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32498 ) Change subject: ctrl: Add penalty time control ...................................................................... Patch Set 4: (1 comment) File src/osmo-bsc/bts_ctrl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/32498/comment/b7698b7b_d7a86e7c PS4, Line 798: CTRL_CMD_DEFINE(bts_penalty_time, "si3-penalty-time"); this field seems to be in si_common so I suspec it's used in more than SI3. Moreover they seem to be in struct osmo_gsm48_si_selection_params, so that already seems to be describing some specific subgroup. In "3GPP TS 45.008" they seem to be named "control parameters". If you are adding these params now it's because I guess you need them so you have the context to provide a proper better naming. Maybe adding an extra subgroup (ctrl node) may be also good, I don't know right now. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32498 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idfdd54dec72fb5f52eee22df018161d75b8c48c8 Gerrit-Change-Number: 32498 Gerrit-PatchSet: 4 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Apr 2023 12:14:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment