Change in osmo-hnodeb[master]: audio: Introduce SAPI v1 with unordered RFCI support - gerrit-log

10 Jun 2022


      Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/28251 )
Change subject: audio: Introduce SAPI v1 with unordered RFCI support
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/osmo-hnodeb/llsk_audio.c:
https://gerrit.osmocom.org/c/osmo-hnodeb/+/28251/comment/416ebe1a_18238767 
PS1, Line 76: 		llsk_audio_prim_size_tbl[PRIM_OP_REQUEST][HNB_AUDIO_PRIM_CONN_ESTABLISH] =
I'm a bit surprised that this modifies a global variable. So there's only one connection with one version possible at the same time?
(I'm sure you thought of that, giving +1 anyway.)
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/28251
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnodeb
Gerrit-Branch: master
Gerrit-Change-Id: I860d18b80c1041bf63a1570d435e0568c0f6b01b
Gerrit-Change-Number: 28251
Gerrit-PatchSet: 1
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Fri, 10 Jun 2022 11:24:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment