Attention is currently required from: fixeria, lynxis lazus. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29788 ) Change subject: Add BTS setup ramping to prevent BSC overloading ...................................................................... Patch Set 3: (4 comments) File include/osmocom/bsc/bts_setup_ramp.h: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/5aa50e91_c674beec PS3, Line 31: BTS_SETUP_RAMP_INIT, /** initial state */ (osmo-bsc doesn't generate doxygen, but just saying: the correct doxygen syntaxes here would be BTS_FOO, /*< foo */ because otherwise it is seen as comment for the subsequent line; or /*! foo */ BTS_FOO because osmocom has decided on '/*!' instead of the IMHO nicer '/**' ) File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/3c286c2a_1a550b19 PS1, Line 1284: "allow-bts-configuration <0-65535>", (i also prefer 'bts <0-255> foo') File src/osmo-bsc/bts_setup_ramp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/7543cc16_6dfc2e05 PS3, Line 62: * \brief Unblock a BTS from BTS setup ramping to allow it to setup and configure. please don't use '\brief', our doxygen config has AUTOBRIEF set https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/56554042_3e428810 PS3, Line 77: * \brief Timer callback and called by bts_setup_ramp_deactivate drop \brief and end the line with a period (same below) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id56dde6d58f3d0d20352f6c306598d2cccc6345d Gerrit-Change-Number: 29788 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus &lt;lynxis(a)fe80.eu&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-CC: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Attention: lynxis lazus &lt;lynxis(a)fe80.eu&gt; Gerrit-Comment-Date: Mon, 24 Oct 2022 21:52:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Comment-In-Reply-To: lynxis lazus &lt;lynxis(a)fe80.eu&gt; Gerrit-MessageType: comment