Attention is currently required from: Hoernchen, lynxis lazus.

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42231?usp=email )

Change subject: remsim-bankd: Don't pass on illegal TPDUs of illegal length ......................................................................

Patch Set 3:

(1 comment)

File src/bankd/bankd_main.c:

https://gerrit.osmocom.org/c/osmo-remsim/+/42231/comment/64496dbc_3fe793be?u... : PS3, Line 826: return -107;

(unresolv it)

The most likely explanation for a short TPDU is that the cardem/tracer somehow failed to correctly receive/decode the command from the modem, possibly due to timing, EMI or a firmware bug or the like.

Well, it's hard to know what is desirable here. If any one APDU in a sequence of APDUs fails, there is no way to know if the state is still consistent. Imagine a SELECT before an UPDATE - you end up writing to the wrong file.

So I think failing fast and fully is a safe approach, rather than simply ignoring errors. But I'm happy to be convinced otherwise...