Attention is currently required from: daniel, dexter, laforge.
fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41508?usp=email )
Change subject: card_key_provider: add PostgreSQL support ......................................................................
Patch Set 7:
(3 comments)
File contrib/csv-to-pgsql.py:
https://gerrit.osmocom.org/c/pysim/+/41508/comment/f886c0de_bb80e006?usp=ema... : PS5, Line 38: table_name
I am not sure, yes we could do the .lower() here. I think its ok to keep the . […]
Consistency with what? Now that you have `.lower()` here, I see no point doing this below.
File contrib/csv-to-pgsql.py:
https://gerrit.osmocom.org/c/pysim/+/41508/comment/6292c988_7e6f1025?usp=ema... : PS7, Line 80: self.table Shouldn't this be `table_names`?
https://gerrit.osmocom.org/c/pysim/+/41508/comment/d13e6ef2_6ce3a423?usp=ema... : PS7, Line 117: str(self.table.lower())) ```suggestion log.info("New database table created: %s", self.table) ```
-
fixeria