Attention is currently required from: fixeria.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/42378?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed: Verified+1 by Jenkins Builder
Change subject: global_platform: make --install-parameters-* independently optional ......................................................................
global_platform: make --install-parameters-* independently optional
gen_install_parameters() had contradictory logic: the outer guard required all three arguments to be non-None/non-empty (making them mutually inclusive), while the inner checks then treated each one as optional.
Make each parameter independently optional (defaulting to None) and remove the all-or-nothing guard from both the function and its caller. Simplify the function body to a straightforward single-pass construction of system_specific_params.
Change-Id: I8756fb38016cdf0527fe2e21edb44381d1dc557f --- M pySim/global_platform/__init__.py M pySim/global_platform/install_param.py M tests/unittests/test_globalplatform.py 3 files changed, 17 insertions(+), 21 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/78/42378/3