tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26793 )
Change subject: e1d/usb: Limit feedback EP transfer size to 3 ......................................................................
e1d/usb: Limit feedback EP transfer size to 3
Newer descriptors have the max packet size set to 3 to save on isochronous bandwidth.
By specs, the feed back endpoints transfer are 24 bits anyway, so no point is using anything larger.
Signed-off-by: Sylvain Munaut tnt@246tNt.com Change-Id: I09e259db539e62571fd17fc16ffaa317564ba257 --- M src/usb.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/93/26793/1
diff --git a/src/usb.c b/src/usb.c index 465aecd..348c104 100644 --- a/src/usb.c +++ b/src/usb.c @@ -583,7 +583,7 @@
line_data->flow_in = e1uf_create(line, e1_usb_xfer_in, line_data->ep_in, 4, line_data->pkt_size, 4); line_data->flow_out = e1uf_create(line, e1_usb_xfer_out, line_data->ep_out, 4, line_data->pkt_size, 4); - line_data->flow_fb = e1uf_create(line, e1_usb_xfer_fb, line_data->ep_fb, 2, 8, 1); + line_data->flow_fb = e1uf_create(line, e1_usb_xfer_fb, line_data->ep_fb, 2, 3, 1);
e1uf_start(line_data->flow_in); e1uf_start(line_data->flow_out);
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26793 )
Change subject: e1d/usb: Limit feedback EP transfer size to 3 ......................................................................
Patch Set 1: Code-Review+2
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26793 )
Change subject: e1d/usb: Limit feedback EP transfer size to 3 ......................................................................
e1d/usb: Limit feedback EP transfer size to 3
Newer descriptors have the max packet size set to 3 to save on isochronous bandwidth.
By specs, the feed back endpoints transfer are 24 bits anyway, so no point is using anything larger.
Signed-off-by: Sylvain Munaut tnt@246tNt.com Change-Id: I09e259db539e62571fd17fc16ffaa317564ba257 --- M src/usb.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved
diff --git a/src/usb.c b/src/usb.c index 465aecd..348c104 100644 --- a/src/usb.c +++ b/src/usb.c @@ -583,7 +583,7 @@
line_data->flow_in = e1uf_create(line, e1_usb_xfer_in, line_data->ep_in, 4, line_data->pkt_size, 4); line_data->flow_out = e1uf_create(line, e1_usb_xfer_out, line_data->ep_out, 4, line_data->pkt_size, 4); - line_data->flow_fb = e1uf_create(line, e1_usb_xfer_fb, line_data->ep_fb, 2, 8, 1); + line_data->flow_fb = e1uf_create(line, e1_usb_xfer_fb, line_data->ep_fb, 2, 3, 1);
e1uf_start(line_data->flow_in); e1uf_start(line_data->flow_out);