Attention is currently required from: arehbein, laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198 ) Change subject: stream: Add client-side (segmentation) support for IPAC ...................................................................... Patch Set 5: (3 comments) File tests/stream/stream_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8576): https://gerrit.osmocom.org/c/libosmo-netif/+/33198/comment/bb5855af_8d68251a PS5, Line 713: osmo_hexdump((const unsigned char *)h, sizeof (*h) + h->len)); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8576): https://gerrit.osmocom.org/c/libosmo-netif/+/33198/comment/f170ed02_ecd2523a PS5, Line 723: int (* test_segm_ipa_stream_cli_srv_close_cb)(struct osmo_stream_srv *conn) = Unnecessary space before function pointer name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8576): https://gerrit.osmocom.org/c/libosmo-netif/+/33198/comment/4b858eb1_289ce8b1 PS5, Line 723: int (* test_segm_ipa_stream_cli_srv_close_cb)(struct osmo_stream_srv *conn) = space prohibited after that '*' (ctx:BxW) -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 5 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 26 Jun 2023 12:44:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment