Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28091 ) Change subject: ggsn: Append ChargingCharacteristics IE to CreatePdpCtxReq ...................................................................... Patch Set 1: Code-Review-1 (2 comments) File library/GTP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28091/comment/9c3a9773_0243… PS1, Line 128: template Field 'chargingChar' is not 'optional', so please add '(present)'. This allows to detect potential bugs at compile-time. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28091/comment/eb119856_6f97… PS1, Line 399: ts_ChargingCharacteristics You cannot pass 'omit' (as default value) to this template. I guess you want a wrapper function returning: if (istemplitekind(charging_char, "omit")) return omit; else return ts_ChargingCharacteristics(charging_char); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia0f74041d2107afeaa36b94e33474370b7b07c0e Gerrit-Change-Number: 28091 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 May 2022 16:42:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment