Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/32321 ) Change subject: add public API: osmo_sccp_instance_next_conn_id() ...................................................................... Patch Set 3: (1 comment) Patchset: PS1: yes, it is actually more correct than anything, because in libosmo-sccp, this internal list is the one that really matters for communicating on SCCP. Let's say the calling program has remembered the conn_id, and when it cleans up, it quickly tells sccp_scoc.c to disconnect and immediately discards its own state for conn_id. sccp_scoc.c will still take a little while to negotiate the SCCP RLSD + RLC for this conn_id. So for that time, the calling program assumes the conn_id is available, while the internal SCCP layer still needs this conn_id to remain unused until RLC arrives. So it is better to use libosmo-sccp's internal list. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/32321 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: If59d524fbe1088a59ae1b69908e2d4bf67113439 Gerrit-Change-Number: 32321 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Apr 2023 16:41:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment