Attention is currently required from: pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/32321 )
Change subject: add public API: osmo_sccp_instance_next_conn_id() ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS1:
I saw not yet any reply regarding my concerns here.
yes, it is actually more correct than anything, because in libosmo-sccp, this internal list is the one that really matters for communicating on SCCP.
Let's say the calling program has remembered the conn_id, and when it cleans up, it quickly tells sccp_scoc.c to disconnect and immediately discards its own state for conn_id. sccp_scoc.c will still take a little while to negotiate the SCCP RLSD + RLC for this conn_id. So for that time, the calling program assumes the conn_id is available, while the internal SCCP layer still needs this conn_id to remain unused until RLC arrives. So it is better to use libosmo-sccp's internal list.