Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30566 )

Change subject: Move first_common_ts from gprs_rlcmac_tbf to GprsMs ......................................................................

Patch Set 2:

(2 comments)

File src/gprs_ms.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/30566/comment/fcf1cb16_45201041 PS2, Line 67: simultaniously

AFAICS, this comment is simply copied as-is from src/tbf.h#b223, except the value range.

Yes, I simply moved the comment. I can change the description as you suggest though.

File src/pcu_vty_functions.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/30566/comment/685ccad5_ba49c39d PS2, Line 64: PRId8

Is there really a need for this change? %d would still work for int8_t, AFAIK.

what's wrong with using the proper type for the variable? In any case, this is changing more in follow up patches.