Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28686 )
Change subject: add cmdline --mockup-gtp for VTY tests ......................................................................
Patch Set 1:
(2 comments)
File src/osmo-upf/osmo_upf_main.c:
https://gerrit.osmocom.org/c/osmo-upf/+/28686/comment/c20f92b1_a2c71ea6 PS1, Line 336: if (upf_gtp_genl_open()) Cannot you keep everything in here in main and simply avoid calling the functions here?
File src/osmo-upf/up_gtp_action.c:
https://gerrit.osmocom.org/c/osmo-upf/+/28686/comment/ccb41102_dfb712c8 PS1, Line 85: LOG_UP_GTP_ACTION(a, LOGL_ERROR, "--mockup-gtp active, skipping GTP action %s\n", definetly not an error.