Attention is currently required from: fixeria, pespin.

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254?usp=email )

Change subject: SGSN: TC_attach_gmm_attach_req_while_gmm_attach: fix test case ......................................................................

Patch Set 8:

(3 comments)

File sgsn/SGSN_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254/comment/916711a3_52b42... : PS8, Line 2069: If the SGSN follows the rules, this 2nd ATTACH REQ should be ignored, because : * of the same content

I am not sure why do we even send GMM ATTACH. […]

This test is about resending a GMM Attach Request, because the MS can send a GMM Attach Request while in the Attach procedure. If it is the same content as send in the 1st Attach Request, ignore it (it could be treated, that the message since GMM Attach Request get lost). If it is not the same, ignore the previous state and redo the Attach procedure.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254/comment/fab04bfb_e881c... : PS8, Line 2116: auth-policy accept-all

Unrelated to this patch: is the authentication mandatory now? You mentioned that the ACL will be rem […]

Yes. First we want to remove it. They might be re-introduced in the same way, as the MSC supports it.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254/comment/6f5b81ba_efc61... : PS8, Line 2098: * MS <- SGSN: Identity Request IMEI :

BTW, this is no longer true since you've removed handling of IDENTITY.req for IMEI.

Done