Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30101 ) Change subject: trxcon: reorganize the core logic into libtrxcon.la ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File src/host/trxcon/src/trxcon_inst.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30101/comment/8fedef72_947b1d01 PS2, Line 31: extern int g_logc_l1c; you could even just store an array here and use it internally: #define LOGFOOBAR() LOGP(g_log_cat[TRXCON_LOGC_L1C], "foobar").... https://gerrit.osmocom.org/c/osmocom-bb/+/30101/comment/c73d0851_c87627c4 PS2, Line 51: schc = logc[i]; so this two aren't used? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30101 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Idf207947f620a7394e0a0e5bf2c37bcd8df64bbe Gerrit-Change-Number: 30101 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Nov 2022 13:06:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment