Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/37212?usp=email )
Change subject: mobile: cosmetic: fix -Wswitch in tch_voice_state_init() ......................................................................
Patch Set 1:
(1 comment)
File src/host/layer23/src/mobile/tch_voice.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/37212/comment/4878e0a4_7ec75460 PS1, Line 135: #endif
is this fine here? that makes it jump into TCH_VOICE_IOH_NONE. […]
It's fine because we cannot end up having `state->handler == TCH_VOICE_IOH_GAPK` if built without `WITH_GAPK_IO`. The VTY does not permit that. So we treat this very unlikely to happen scenario the same way as `TCH_VOICE_IOH_NONE`.
I don't see a need to add `/* fall through */` here because the pre-processor will produce the following code when building without `WITH_GAPK_IO`:
``` case TCH_VOICE_IOH_GAPK: case TCH_VOICE_IOH_NONE: rr->audio_mode = 0x00; break; ```