Attention is currently required from: pespin.

View Change

1 comment:

• File src/host/layer23/src/mobile/tch_voice.c:

  • Patch Set #1, Line 135: #endif

    is this fine here? that makes it jump into TCH_VOICE_IOH_NONE. […]

    It's fine because we cannot end up having `state->handler == TCH_VOICE_IOH_GAPK` if built without `WITH_GAPK_IO`. The VTY does not permit that. So we treat this very unlikely to happen scenario the same way as `TCH_VOICE_IOH_NONE`.

    I don't see a need to add `/* fall through */` here because the pre-processor will produce the following code when building without `WITH_GAPK_IO`:

    ```
    case TCH_VOICE_IOH_GAPK:
    case TCH_VOICE_IOH_NONE:
    	rr->audio_mode = 0x00;
    	break;
    ```

To view, visit change 37212. To unsubscribe, or for help writing mail filters, visit settings.