Attention is currently required from: fixeria.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/gapk/+/34892?usp=email )
Change subject: dist: exclude libgsmhr files downloaded by fetch_sources.py ......................................................................
Patch Set 1:
(1 comment)
File libgsmhr/Makefile.am:
https://gerrit.osmocom.org/c/gapk/+/34892/comment/e743eb8e_54f4866d PS1, Line 39: -rm -rf $(distdir)/$(REFSRC_PATH) I think removing the sources in a dist-hook is a good idea, so they don't end up in the archive by accident if they were already downloaded.
However downloading the sources first even if we don't intend to package them, and then remove them, seems like an unclean solution. Can't we additionally change it so they don't get downloaded in the first place unless --enable-gsmhr is set?
-
osmith