Attention is currently required from: dexter, fixeria, neels.

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41690?usp=email )

Change subject: pySim.esim.saip.personalization: Support Milenage customization ......................................................................

Patch Set 2:

(5 comments)

File pySim/esim/saip/personalization.py:

https://gerrit.osmocom.org/c/pysim/+/41690/comment/1948a1f7_972b23ff?usp=ema... : PS1, Line 327: Provided as octet-string concatenation of all 5 constants."""

Which type exactly goes into the PES? […]

yes, it's 5 bytes, each of which contains an uint8_t whose value shall not exceed 127.

btw, the default value is ``` rotationConstants OCTET STRING (SIZE (5)) DEFAULT '4000204060'H,

``` i.e. this will be used if the user doesn't provide any override for this ConfigurableParameter

https://gerrit.osmocom.org/c/pysim/+/41690/comment/2222a348_b4c93b29?usp=ema... : PS1, Line 331: raise('Length of value must be 5 octets')

Raise an exception, not a string (linter).

Done

https://gerrit.osmocom.org/c/pysim/+/41690/comment/d2b4dc86_02fd838c?usp=ema... : PS1, Line 340: raise('Length of value must be 80 octets')

Raise an exception, not a string (linter).

Done

https://gerrit.osmocom.org/c/pysim/+/41690/comment/7635a2a8_7c68e04a?usp=ema... : PS1, Line 341: super().validate()

(On my branch I will inherit from BinaryParam,AlgoConfig and set allowed_len, so this won't need its […]

Done

https://gerrit.osmocom.org/c/pysim/+/41690/comment/db4dd2ad_672a2160?usp=ema... : PS1, Line 343: """Number of iterations of Keccak-f[1600] permuitation as recomended by Section 7.2 of 3GPP TS 35.231"""

question from the future: what is a good default value for this? is 1 ok? thx!

Yes, 1 is the default as specified in 3GPP TS 35.231. It is also what the SAIP ASN.1 definition lists as default if the field is absent: ``` numberOfKeccak UInt8 DEFAULT 1 ```