Attention is currently required from: pespin.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-upf/+/27218
)
Change subject: libosmo-tlv: add auto dec/enc to/from structs
......................................................................
Patch Set 1:
(2 comments)
File include/osmocom/tlv/tlv_dec_enc.h:
https://gerrit.osmocom.org/c/osmo-upf/+/27218/comment/4aad041b_9ceb7109
PS1, Line 60: OSMO_TLV_NESTED_IES_ORDERED_SAME = 0,
This is not really clear. […]
ok, will clarify
https://gerrit.osmocom.org/c/osmo-upf/+/27218/comment/28fbe195_fec47fb6
PS1, Line 135: * In this example, the nested IEs decode/encode to different goo sub
structs depending on the tag value.
goo? the table game?
well, we often use foo,
bar, baz, but i also like to use foo, goo, moo etc.
Because "fubar" has military connotation and is pretty vulgar, too.
I know World Of Goo as a computer game. is there a table game? I only know the absolutely
magnificent and stunning board game Go, is it even a game.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-upf/+/27218
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I65de793105882a452124ee58adb0e58469e6e796
Gerrit-Change-Number: 27218
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 18 Feb 2022 13:19:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment