Attention is currently required from: fixeria, laforge.
laforge has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/libosmo-gprs/+/39187?usp=email )
Change subject: rlcmac: fix EGPRS BEP Link Quality Measurements Type 2
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-gprs/+/39187/comment/60817bd2_126d9974… :
PS1, Line 9: is IE is defined in 3GPP TS 44.060 Table 12.5a.2.1.
might manke sense to add the spec reference directly above the struct definition?
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/39187?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: Iac4de18ef25386f774bb409201b7a7996d1c8824
Gerrit-Change-Number: 39187
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 21 Dec 2024 13:31:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes