pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40575?usp=email )
Change subject: ipa: tear down conn trying to add >16th ASP to AS ......................................................................
ipa: tear down conn trying to add >16th ASP to AS
If a user tries to add more than 16 ASPs to an AS, it will fail internally. In that scenario, close the connection.
Change-Id: Iaf02f69c7a53827037ec500ce946b947ab5ea2bd --- M src/xua_asp_fsm.c 1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/75/40575/1
diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c index 86d86b7..70fb0b3 100644 --- a/src/xua_asp_fsm.c +++ b/src/xua_asp_fsm.c @@ -1124,7 +1124,11 @@ iafp->ipa_unit->unit_name); goto out_err; } - ss7_as_add_asp(as, asp); + rc = ss7_as_add_asp(as, asp); + if (rc < 0) { + LOGPFSML(fi, LOGL_ERROR, "Cannot add ASP '%s' to AS '%s'\n", asp->cfg.name, as->cfg.name); + goto out_err; + } /* TODO: OAP Authentication? */ /* Send ID_ACK */ if (fd >= 0) {