tnt has submitted this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39154?usp=email )

Change subject: dahdi-base: Allow reselection of the same clock master ......................................................................

dahdi-base: Allow reselection of the same clock master

__dahdi_find_master_span is called from a bunch of different places, like when a span comes on-line, this is to potentially select a new master.

However the way it's written now, when it's called, it will ALWAYS tried to find a DIFFERENT master than what is selected now if there is another available, no matter is the current one is earlier in the list.

Change-Id: Ibe2365953c5ac7f3dcc7c10526b9eb797ea320ee Signed-off-by: Sylvain Munaut tnt@246tNt.com --- M drivers/dahdi/dahdi-base.c 1 file changed, 0 insertions(+), 2 deletions(-)

Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve tnt: Looks good to me, approved; Verified

diff --git a/drivers/dahdi/dahdi-base.c b/drivers/dahdi/dahdi-base.c index ef29c4b..43948bd 100644 --- a/drivers/dahdi/dahdi-base.c +++ b/drivers/dahdi/dahdi-base.c @@ -3995,8 +3995,6 @@ continue; if (!can_provide_timing(s)) continue; - if (master_span == s) - continue;

master_span = s; break;