Attention is currently required from: falconia, jolly.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35132?usp=email )

Change subject: Transmit invalid AMR speech blocks instead of dummy FACCH ......................................................................

Patch Set 2:

(2 comments)

File src/osmo-bts-trx/sched_lchan_tchf.c:

https://gerrit.osmocom.org/c/osmo-bts/+/35132/comment/325da77a_20c4b21a PS2, Line 541: * - If the channel mode is AMR, transmit a dummy with speech I'd document here the rationale about "FACCH displaces two speech frames rather than one".

https://gerrit.osmocom.org/c/osmo-bts/+/35132/comment/dd18f27e_42886a15 PS2, Line 578: dummy_facch: Maybe moving the GSM48_CMODE_SPEECH_AMR case inside the default with an "if" block is cleaner than adding a goto here...