Attention is currently required from: fixeria, pespin.

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31415 )

Change subject: bts_features: Add features for HR formats (TS 101813 vs. RFC5993) ......................................................................

Patch Set 2:

(2 comments)

Patchset:

PS1:

Indeed, these can be internal BTS flags. […]

The flags were once internal flags. The approach changed. Now the BSC needs to know the preferred format to generate the SDP strings for the MGW.

osmo-bts only supports both format in the RX path, in the TX path it still transmits on the native format.

File include/osmocom/gsm/bts_features.h:

https://gerrit.osmocom.org/c/libosmocore/+/31415/comment/5c861305_eac0bed4 PS1, Line 39: BTS_FEAT_SPEECH_H_V1_RFC5993, /* Whether the BTS model supports HR GSM RTP payload in RFC 5883 format */

in same line you say RFC 5993 and 5883. One is wrong.

Done