Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/29614 )
Change subject: Add Osmux IPv6 support
......................................................................
Patch Set 3: Code-Review+1
(5 comments)
File src/libosmo-mgcp/mgcp_network.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/29614/comment/2d62e8f8_0885eb66
PS2, Line 102: if (mgcp_conn_rtp_is_osmux(conn)) {
I'll submit that as a followup patch.
Done
File src/libosmo-mgcp/mgcp_osmux.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/29614/comment/040f8aa8_1800da96
PS2, Line 459: cfg->osmux_addr_v4, cfg->osmux_port);
broken alignment
Done
https://gerrit.osmocom.org/c/osmo-mgw/+/29614/comment/adbe4fdf_e2bd7117
PS2, Line 466: osmo_sock_get_name2(osmux_fd_v4.fd));
broken alignment
Done
https://gerrit.osmocom.org/c/osmo-mgw/+/29614/comment/841f1574_318fddd6
PS2, Line 477: cfg->osmux_addr_v6, cfg->osmux_port);
broken alignment
Done
https://gerrit.osmocom.org/c/osmo-mgw/+/29614/comment/3479b144_fd4204ab
PS2, Line 484: osmo_sock_get_name2(osmux_fd_v6.fd));
broken alignment
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/29614
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I446cd7da217e9f4a74995d7784ae55dcc60a29b7
Gerrit-Change-Number: 29614
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 05 Oct 2022 08:40:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment