fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/38377?usp=email ) Change subject: diameter: fix wrong 'Vendor-Id' value (should be 3GPP) ...................................................................... diameter: fix wrong 'Vendor-Id' value (should be 3GPP) Wireshark decodes VID=10515 as follows: Vendor-Id: Terry Nazon Inc (10515) Looks like a typo, it should be VID=10415: Vendor-Id: 3GPP (10415) At least this is what open5gs is using. Change-Id: I601785a8c71e9c6e6d94018586e2a865ba8b2f11 --- M src/osmo_dia2gsup.erl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/osmo_dia2gsup.erl b/src/osmo_dia2gsup.erl index d1c9fda..7aabc1c 100644 --- a/src/osmo_dia2gsup.erl +++ b/src/osmo_dia2gsup.erl @@ -58,7 +58,7 @@ -define(CALLBACK_MOD, server_cb). -define(DIAMETER_DICT_HSS, diameter_3gpp_ts29_272). --define(APPID_S6, #'diameter_base_Vendor-Specific-Application-Id'{'Vendor-Id'=10515, 'Auth-Application-Id'=[16777251]}). +-define(APPID_S6, #'diameter_base_Vendor-Specific-Application-Id'{'Vendor-Id'=10415, 'Auth-Application-Id'=[16777251]}). -define(SERVICE(Name), [{'Origin-Host', application:get_env(osmo_dia2gsup, origin_host, "hss.localdomain")}, {'Origin-Realm', application:get_env(osmo_dia2gsup, origin_realm, "localdomain")}, {'Vendor-Id', application:get_env(osmo_dia2gsup, vendor_id, 0)}, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/38377?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I601785a8c71e9c6e6d94018586e2a865ba8b2f11 Gerrit-Change-Number: 38377 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>