Attention is currently required from: fixeria.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/28784
)
Change subject: sdp_msg: s/sdp_audio_codec_/sdp_audio_codecs_
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-msc/+/28784/comment/e46f9ac2_2b0d4244
PS3, Line 9: act on a struct sdp_audio_codecs
But they all return a struct sdp_audio_codec
(singular), so I guess it's fine?
hmm incidentally yes, but this is intended to
be API for struct sdp_audio_codecs, and i think my intention was for them to fit in with
sdp_audio_codecs_cmp() and sdp_audio_codecs_intersection(). (wrote this a long time ago)
either way i would like to keep this patch to not cause merge conflict resolution cascades
in the rest of the codecs branch
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/28784
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Id87eb350c1f17f8dbf776909824bfa06634c1d04
Gerrit-Change-Number: 28784
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 28 Jul 2022 14:11:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment