[S] Change in libosmocore[master]: gsm0808: add knowledge of TW-TS-003 BSSMAP IE - gerrit-log

31 May 2024

Attention is currently required from: falconia, fixeria, neels.

laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/36669?usp=email )

Change subject: gsm0808: add knowledge of TW-TS-003 BSSMAP IE
......................................................................

Patch Set 3: Code-Review+2

(1 comment)

Patchset:

PS3: 
...
  I'm in two minds here; this seems to be a single
person effort. 
One very dedicated person who has proven certainly beyond doubt the level of dedication;
I'm not worried here.

...
  This stuff puts me off  
I find it rather amusing [not sure if it's intended that way] and the entire format of
those specs could possibly even be read as a parody of the way those specs are typicaly
written.

...
  In general I'm critical to "RTP
extension". RTP is maximally flexible by allowing any payload types to be used, even
if they are pure fantasy. 
https://www.freecalypso.org/specs/tw-ts-002-v010100.txt contains an explanation why now
different/new payload types are introduced.

...
  Adding custom IEs to BSSMAP is not done in osmocom
yet, and we have no way of indicating the BSS' custom capabilities to osmo-msc. How do
you solve that? 
It would likely have to be configured/enabled out of band on both BSC and MSC side.  For
sure we cannot merge patches that would unconditionally introduce sending non-standard IEs
on the A interface. Bu that's not happening here.

...
  BTW, if we have custom BSSMAP IEs, then I might want
to add an IE to use an array of octets to describe all permitted AMR bitrates in a sane
way  
you can do thay, if you'd like to do it - however it would of course only work in a
fully osmo-* network, and not have significance outside of that osmo-only deployment.

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36669?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Idd6f1838bdc0cd71a2f6357e9b6d8b8fa4f7c46c
Gerrit-Change-Number: 36669
Gerrit-PatchSet: 3
Gerrit-Owner: falconia &lt;falcon(a)freecalypso.org&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-CC: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Gerrit-Attention: falconia &lt;falcon(a)freecalypso.org&gt;
Gerrit-Attention: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Comment-Date: Fri, 31 May 2024 09:05:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Gerrit-MessageType: comment