Attention is currently required from: pespin.

Hello Jenkins Builder, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/39276?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed: Code-Review-1 by pespin, Verified+1 by Jenkins Builder

Change subject: osmo_iofd_register: fix the case of changing fd ......................................................................

osmo_iofd_register: fix the case of changing fd

Doxygen description for this function states:

\param[in] fd the system fd number that will be registered. If you did not yet specify the file descriptor number during osmo_fd_setup(), or if it has changed since then, you can state the [new] file descriptor number as argument. If you wish to proceed with the previously specified file descriptor number, pass -1.

However, the case where a new fd is passed to osmo_iofd_register() while the structure contains an old (but unregistered) fd was not handled correctly: the code would proceed with re-registering the old fd, ignoring the newly passed one.

Fixes: df1ee8568b97dbf6d5268a83d1715a1c1fffb2de Change-Id: If8b8486ad7934afa203dfe1e996c9217373a017b --- M src/core/osmo_io.c 1 file changed, 13 insertions(+), 11 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/76/39276/2