Attention is currently required from: laforge.
Hoernchen has posted comments on this change by Hoernchen. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759?usp=email )
Change subject: Make ch9 usb tests work
......................................................................
Patch Set 2:
(4 comments)
File contrib/ch9_epstall.py:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/c1ebedac_68…
:
PS1, Line 3: ch9 usb ep halt test
Does that test have a name/number? If so, it would be
good to add as a spec reference.
Done
File contrib/gdb_clocktree.py:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/4f1d368a_b8…
:
PS1, Line 1: import gdb
please add copyright/author and at least a brief
summary.
Done
File contrib/gdb_sercom.py:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/794b71d1_c8…
:
PS1, Line 1: import gdb
a line with author / copyright information is missing,
and at least a very high-level description of […]
Done
File contrib/gdb_usb.py:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/34c176e3_45…
:
PS1, Line 3:
same here: copyright/author/brief description
there will not be a description because i specifically said snippets which means
collection of random code fragments that might or might not be useful. nothing is useful
as is. i just don't want to poke google every time some arcane gdb python bullshit
acts up again.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Icadaee9d8cbe24bd3cac002cc4f710dcf846a32b
Gerrit-Change-Number: 39759
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 11 Mar 2025 17:47:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>