Attention is currently required from: neels.
laforge has posted comments on this change by neels. (
https://gerrit.osmocom.org/c/pysim/+/39745?usp=email )
Change subject: [5/6] personalization: refactor AlgorithmID, K, Opc
......................................................................
Patch Set 8: Code-Review+1
(1 comment)
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/39745/comment/e4f9b95d_de22b546?usp=em… :
PS3, Line 551: allow_len = int(128/8) # length in bytes (from BinaryParam)
I'm sorry, I do not comprehend this code snippet
at all... […]
the bit lengths are specified in the construct: key length can be 128
or 256 bits
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/39745?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I6296fdcfd5d2ed313c4aade57ff43cc362375848
Gerrit-Change-Number: 39745
Gerrit-PatchSet: 8
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 06 Aug 2025 12:08:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>