Change in osmo-bsc[master]: pcu_sock: check trx mo state - gerrit-log

5 Jan 2023


      Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30875 )
Change subject: pcu_sock: check trx mo state
......................................................................
Patch Set 2:
(1 comment)
File src/osmo-bsc/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30875/comment/7eba179e_b3298559 
PS2, Line 117: 	if (trx->mo.nm_state.operational != NM_OPSTATE_ENABLED || trx->mo.nm_state.administrative != NM_STATE_UNLOCKED) {
Better put this into 2 lines like in osmo-bts.git, it's much more easier to read:
    if (trx->mo.nm_state.operational != NM_OPSTATE_ENABLED ||
        trx->mo.nm_state.administrative != NM_STATE_UNLOCKED) {
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30875
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I7a93826e6b0df187425310cb82854e7d7fb47e72
Gerrit-Change-Number: 30875
Gerrit-PatchSet: 2
Gerrit-Owner: dexter pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Thu, 05 Jan 2023 17:00:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment