Attention is currently required from: dexter, falconia, fixeria. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38290?usp=email ) Change subject: libosmotrau: add CSD RA2 functions ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File include/osmocom/trau/csd_ra2.h: https://gerrit.osmocom.org/c/libosmo-abis/+/38290/comment/c0eb7e9b_13a41edb… : PS1, Line 58: here he nbytes indicates the number of _output_ bytes. https://gerrit.osmocom.org/c/libosmo-abis/+/38290/comment/67f8356e_c67f806d… : PS1, Line 66: ubit_t so here the nbytes indicats the number of _input_ bytes. I find that a bit confusing. Maybe call the parameter n_out_bytes / n_in_bytes to make it more obvious? Not critical, but just a thought. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38290?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I7b98b958651b3fc1a814d119d1b8644c91f98676 Gerrit-Change-Number: 38290 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Sep 2024 21:16:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes