Change in osmo-iuh[master]: ranap_common_ran: add decoder for CN/MSC originated messages - gerrit-log

31 Jan 2022

Attention is currently required from: laforge, fixeria.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26955
)

Change subject: ranap_common_ran: add decoder for CN/MSC originated messages
......................................................................

Patch Set 6:

(6 comments)

Patchset:

PS5: 
...
  I think they are rather critical, thanks for finding
them! Thanks for reviewing this.

File include/osmocom/ranap/ranap_common.h:

https://gerrit.osmocom.org/c/osmo-iuh/+/26955/comment/adddf1bf_971d785d 
PS5, Line 599: funktions
...
  Tippfehler: functions Done

File src/ranap_common_ran.c:

https://gerrit.osmocom.org/c/osmo-iuh/+/26955/comment/53eece89_29e35e55 
PS5, Line 90: unsuccessfulOutcome
...
  successfulOutcome? I think it's not critical,
given that 'procedureCode' is present in all union mem […] Oh, thats indeed
wrong.

https://gerrit.osmocom.org/c/osmo-iuh/+/26955/comment/b2a9c055_5a06f869 
PS5, Line 102: unsuccessfulOutcome
...
  outcome? I think it's not critical, given that
'procedureCode' is present in all union members at th […] Done

https://gerrit.osmocom.org/c/osmo-iuh/+/26955/comment/6afc7803_8b20c04e 
PS5, Line 124: unsuccessful
...
  copy-paste: successful Done

https://gerrit.osmocom.org/c/osmo-iuh/+/26955/comment/6811ad06_5e934f42 
PS5, Line 132: unsuccessful
...
  Neither unsuccessful not successful, so this word
should be removed. Done

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26955
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: Iad4c2743d4d1ddf8ad49002d1fe6866f22eb9e98
Gerrit-Change-Number: 26955
Gerrit-PatchSet: 6
Gerrit-Owner: dexter &lt;pmaier(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-CC: daniel &lt;dwillmann(a)sysmocom.de&gt;
Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-CC: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Comment-Date: Mon, 31 Jan 2022 16:42:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge &lt;laforge(a)osmocom.org&gt;
Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-MessageType: comment