Change in libosmocore[master]: Introduce tundev API - gerrit-log

19 Jan 2023


      Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31025 )
Change subject: Introduce tundev API
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
File src/core/tun.c:
https://gerrit.osmocom.org/c/libosmocore/+/31025/comment/16305262_de2e150b 
PS4, Line 87: bu
by?
https://gerrit.osmocom.org/c/libosmocore/+/31025/comment/fd4920ee_d67780f2 
PS4, Line 421: osmo_tundev_encaps
probably just my personal point of view, but let's see if others agree: I find it a bit odd to call a function _encaps() if it's not actually doing any encapsulation.  _transmit? _write? _send?
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31025
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I3463271666df1e85746fb7b06ec45a17024b8c53
Gerrit-Change-Number: 31025
Gerrit-PatchSet: 4
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Thu, 19 Jan 2023 20:54:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment