Change in osmocom-bb[master]: trxcon: rework TRXC/TRXD cleanup logic, add trx_fsm_cleanup_cb() - gerrit-log

1 Aug 2022


      Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28861 )
Change subject: trxcon: rework TRXC/TRXD cleanup logic, add trx_fsm_cleanup_cb()
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/host/trxcon/src/trx_if.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/28861/comment/53102348_9ecd2e58 
PS1, Line 746: 	talloc_reparent(trxcon, trx->fi, trx);
This is all a bit convoluted. If trx ends up in trx->fi, why not first allocate "fi" and then "trx = talloc_zero(fi, struct trx_instance);"?
-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28861
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ic599b51067cb5a331fca521a5b46ab0a2804e499
Gerrit-Change-Number: 28861
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Mon, 01 Aug 2022 09:02:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment