Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41215?usp=email ) Change subject: testenv: add --install-packages ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File _testenv/testenv/__init__.py: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41215/comment/c5be7266_2cbf… : PS1, Line 215: packages Nitpick: package(s) suggests that you can specify more than one package, like `--install-packages "foo bar zoo"`, but the `metavar` is `PACKAGE`. Maybe call it `--install-package` (without the 's') to avoid confusion? Alternatively, maybe change to use `type=str` and then do `testenv.args.install_packages.split(' ')`? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41215?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie54817e6c0334a224a612521beb378537c10d39d Gerrit-Change-Number: 41215 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 11 Oct 2025 07:45:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes