Attention is currently required from: fixeria, laforge, osmith.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/libosmocore/+/40295?usp=email )
Change subject: Introduce tests/osmo-config-merge testsuite
......................................................................
Patch Set 6:
(2 comments)
File tests/osmo-config-merge/Makefile.am:
https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/69aa6425_05f2c4b5?… :
PS4, Line 25: } >'$(srcdir)/package.m4'
Done
I had to readd it otherwise the build
failed with:
/bin/bash /build/missing --run autom4te --language=autotest -I
'/build/tests/osmo-config-merge' -o /build/tests/osmo-config-merge/testsuite.tmp
/build/tests/osmo-config-merge/testsuite.at
/build/tests/osmo-config-merge/testsuite.at:1: error: : AT_PACKAGE_BUGREPORT is
missing, consider writing package.m4
File tests/osmo-config-merge/testA.ok:
https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/a83e3caa_3c41fb7c?… :
PS4, Line 74: power-ramp step-size 8000 mdB
: power-ramp step-interval 1
: phy 0 instance 0
: power-ramp step-size 2000 mdB
Yes it's correct afaict, osmo-config-merge
doesn't know about vty command internals and hence cannot […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/40295?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia172d4c280f4bae1b411ad805cca02355ca7fcc9
Gerrit-Change-Number: 40295
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 15 May 2025 17:27:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>