[M] Change in pysim[master]: [2/7] personalization: refactor ConfigurableParameter, Iccid, Imsi - gerrit-log

10 Mar 2025

Attention is currently required from: fixeria.

neels has posted comments on this change by neels. (
https://gerrit.osmocom.org/c/pysim/+/39742?usp=email )

Change subject: [2/7] personalization: refactor ConfigurableParameter, Iccid, Imsi
......................................................................

Patch Set 5:

(1 comment)

File pySim/esim/saip/personalization.py:

https://gerrit.osmocom.org/c/pysim/+/39742/comment/eb89480e_6ba48005?usp=em… :
PS4, Line 42: Subclasses have to implement the apply_val() classmethods
...
  (re "it didn't work": in two ways: i
could not get is_abstract() to return True, and also it turned  […]
@abc.abstractmethod is back

-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/39742?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8
Gerrit-Change-Number: 39742
Gerrit-PatchSet: 5
Gerrit-Owner: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Comment-Date: Mon, 10 Mar 2025 13:02:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;