Attention is currently required from: fixeria, laforge.
dexter has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42310?usp=email )
Change subject: global_platform: install_cap_parser: argument groups cannot be nested
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
File pySim/global_platform/__init__.py:
https://gerrit.osmocom.org/c/pysim/+/42310/comment/05344e8c_d2a12e07?usp=ema... :
PS2, Line 904: opts.install_parameters_stk is None:
When one of the --install-parameters-* is missing we throw an exception. Maybe move this code part to the if branch above and compare with "not None"?
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/42310?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Idddf72d5a745345e134b23f2f01e0257d0667579
Gerrit-Change-Number: 42310
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Tue, 17 Mar 2026 14:58:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes