osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33394 ) Change subject: gsm48_cc_tx_alerting: check rc of sdp_msg_from_sdp_str ...................................................................... gsm48_cc_tx_alerting: check rc of sdp_msg_from_sdp_str Fixes: CID#321280 Change-Id: Id372d2d844446d6667a00dae22bdf8ed36c599ba --- M src/libmsc/gsm_04_08_cc.c 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c index 1d99421..5664f4c 100644 --- a/src/libmsc/gsm_04_08_cc.c +++ b/src/libmsc/gsm_04_08_cc.c @@ -1110,6 +1110,7 @@ struct gsm_mncc *alerting = arg; struct msgb *msg = gsm48_msgb_alloc_name("GSM 04.08 CC ALERT"); struct gsm48_hdr *gh = (struct gsm48_hdr *) msgb_put(msg, sizeof(*gh)); + int rc; gh->msg_type = GSM48_MT_CC_ALERTING; @@ -1128,7 +1129,11 @@ if (alerting->sdp[0]) { struct call_leg *cl = trans->msc_a->cc.call_leg; struct rtp_stream *rtp_cn = cl ? cl->rtp[RTP_TO_CN] : NULL; - sdp_msg_from_sdp_str(&trans->cc.remote, alerting->sdp); + + rc = sdp_msg_from_sdp_str(&trans->cc.remote, alerting->sdp); + if (rc < 0) + return rc; + trans_cc_filter_run(trans); LOG_TRANS(trans, LOGL_DEBUG, "msg_type=%s\n", get_mncc_name(alerting->msg_type)); if (rtp_cn) { -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33394 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Id372d2d844446d6667a00dae22bdf8ed36c599ba Gerrit-Change-Number: 33394 Gerrit-PatchSet: 2 Gerrit-Owner: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-MessageType: merged