Attention is currently required from: laforge, osmith, pespin.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35287?usp=email )

Change subject: stream_srv_link: osmo_stream_srv_link_get_sockname() now returns the full set of addresses ......................................................................

Patch Set 3:

(1 comment)

File src/stream_srv.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/35287/comment/90c7e23c_94a6a750 PS3, Line 371: NULL in case of error

the fact that the implementation internally doesn't fail right now doesn't mean I should change the […]

But you're actually changing the API: this function does not return NULL on error anymore, but would print the error into the output buffer. I am fine with keeping `\returns ... NULL in case of error`, but the `<error>` behavior should definitely be documented. The caller would need to do `strcmp(ret, "<sockname-error>") == 0` instead of `ret == NULL` after your patch.