Attention is currently required from: laforge, osmith, pespin.

View Change

1 comment:

• File src/stream_srv.c:

  • Patch Set #3, Line 371: NULL in case of error

    the fact that the implementation internally doesn't fail right now doesn't mean I should change the […]

    But you're actually changing the API: this function does not return NULL on error anymore, but would print the error into the output buffer. I am fine with keeping `\returns ... NULL in case of error`, but the `<error>` behavior should definitely be documented. The caller would need to do `strcmp(ret, "<sockname-error>") == 0` instead of `ret == NULL` after your patch.

To view, visit change 35287. To unsubscribe, or for help writing mail filters, visit settings.