Attention is currently required from: Bjoern Riemer. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26959 ) Change subject: implement shell command to update PLMN in IMSI ...................................................................... Patch Set 1: Code-Review-1 (2 comments) File pySim/ts_51_011.py: https://gerrit.osmocom.org/c/pysim/+/26959/comment/6f929f4f_d99beccc PS1, Line 485: string There is no such type in Python, should be 'str' instead. https://gerrit.osmocom.org/c/pysim/+/26959/comment/679e39f7_c3b50569 PS1, Line 488: if len(plmn) == 5: If I am not mistaken, it can also be 6 in case of 3-digit MNC. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26959 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9662ff074acf9dc974ae4c78edac44db286e98fc Gerrit-Change-Number: 26959 Gerrit-PatchSet: 1 Gerrit-Owner: Bjoern Riemer <bjoern.c3(a)nixda.biz> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Bjoern Riemer <bjoern.c3(a)nixda.biz> Gerrit-Comment-Date: Fri, 21 Jan 2022 08:41:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment