Attention is currently required from: Hoernchen, lynxis lazus, pespin.
laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email )
Change subject: ccid: fix rdr_to_pc_parameters and rdr_to_pc_hardware_error
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157/comment/517e6a8c_46d... :
PS1, Line 8:
Please describe your commit with more than just "fix message a and b". […]
@ewild@sysmocom.de please kindly mind your tone. It is fine to disagree on technical matters, but there is no need to resort to that kind of language/wording.
In terms of the criticism of @acouzens: I do think both points are valid.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I67d5cb876d20b29f4759d5b194606f34b8b966c4
Gerrit-Change-Number: 42157
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen
ewild@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus
lynxis@fe80.eu
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-CC: laforge
laforge@osmocom.org
Gerrit-Attention: Hoernchen
ewild@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: lynxis lazus
lynxis@fe80.eu
Gerrit-Comment-Date: Sun, 22 Feb 2026 15:57:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen
ewild@sysmocom.de
Comment-In-Reply-To: lynxis lazus
lynxis@fe80.eu