Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28245 ) Change subject: install libosmo-gtlv, libosmo-pfcp ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS1: It is a difficult question, and as neels has pointed out, one that has not really been properly resolved in our overall repository structure. * the libosmo-mgcp-client example is not applicable, as it really is only needed by code talking to osmo-mgw; likewise libosmo-gsup in osmo-hlr.git. Those are both fine, IMHO. * we do have other "strange" examples like osmo-stp being in libosmo-sccp.git. This is odd and should have been done properly from the start, as cleaning this up later means touching every bit of our infrastructure (from packaging recipes to OBS jobs, jenkins jobs and finally ansible playbooks, sysmoNITB stuff, etc.). So if we already know that libosmo-pfcp is [in the osmocom universe] only used internally by UPF or to talk to osmo-upf [or maybe some other upf] it is fine to keep it in osmo-upf.git. This reflects the MGCP-client, GSUP-client or even libgtp/ggsn situation. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28245 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I9f4651b6bee457583aba99052dc82bbf675515e6 Gerrit-Change-Number: 28245 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Jun 2022 04:12:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment